Re: [xml] libxml-2.0.pc

[Daniel Veillard <veillard redhat com>]

On Mon, Jun 13, 2005 at 04:16:11PM +0200, Danilo Šegan wrote:
> Today at 11:18, Daniel Veillard wrote:
> 
> > On Mon, Jun 13, 2005 at 11:07:17AM +0200, lode leroy wrote:
> >> I think that in libxml-2.0.pc the line Cflags should read
> >> Cflags: -I${includedir} -I${includedir}/libxml2
> >> instead of
> >> Cflags: -I${includedir}/libxml2 -I${includedir}/libxml2
> >
> >   Hum, I dislike that. You should never write code doing
> >     #include <libxml2/libxml/....h>
> > Can you justify your suggestion ?
> 
> The problem is with the same path being repeated (though, it's not a
> problem per se, because compiler wouldn't mind that at all).

  There is some redundancy. The file is generated from libxml-2.0.pc.in:

Cflags: -I${includedir}/libxml2 @XML_INCLUDEDIR@ @XML_CFLAGS@

and configure.in shows

XML_INCLUDEDIR='-I${includedir}/libxml2'
[...]
    XML_INCLUDEDIR="${XML_INCLUDEDIR} -I$with_iconv/include"
[...]
AC_SUBST(XML_INCLUDEDIR)

  It seems the first -I${includedir}/libxml2 in libxml-2.0.pc.in could
be removed, true, but the original mail didn't say why, it's always
dangerous to make such changes without a real check. And the actual 
change suggested was just wrong actually IMHO.

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/