Re: [xml] relaxng and xml schema problem (leak/crash)

[Daniel Veillard <veillard redhat com>]

On Sun, Jun 12, 2005 at 01:35:11AM +0800, William M. Brack wrote:
> Rob Richards said:
> > Just synched up with cvs and getting a crash with the following relaxng.
> > Not all familiar with relaxng and schema code, so debugging taking a while.
> > I am guessing that the crash is from changes to schematypes for
> > streaming support (leaks I see are related to changes made for specific
> > basic types).
> 
> Over the last couple of days I submitted to CVS some non-trivial changes to
> the XPath streaming code.  These affect both XPath/xslt and schemas, and
> caused two schemas regression tests to fail.  Kasimier hasn't yet had a chance
> to go through and check whether the failures are caused by problems within the
> schemas code, or errors in my changes.  I'm sure we would both appreciate
> anything you can find - the changes I made are to pattern.c (xpath.c was also
> changed, but those changes won't affect schemas), and are a combination of the
> last two revisions.

  I looked quickly at Rob's bug. It's a problem in relaxng and while I'm
surprized it ain't caught by the existing regression tests, seems fairly
contained. I though I had a patch ready but I was wrong. I need a bit of testing
but it should be fixeable easilly. I don't think it's directly related to 
the streaming. The bug seems to be in xmlRelaxNGSchemaTypeCompare() when
there is an error, we free the base value passed from the to, which then
crash when we free the RNG schemas later. That should be relatively easy
to fix...

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/