Re: [xml] [PATCH] HTTP resource escaping/unescaping fails with quoted URLs

[Daniel Veillard <veillard redhat com>]

On Fri, Jan 10, 2003 at 04:46:26PM +0100, Stefano Zacchiroli wrote:
> On Thu, Dec 12, 2002 at 04:43:49PM -0500, Daniel Veillard wrote:
> >   and provide a patch. Make it checked for Windows paths and verify it
> > passes asll libxml2 and libxslt regression tests. Then you issue
> > will get fixed promptly if you don't suggest to make silly things
> > like changing APIs
> 
> I attach a patch that seems to solve the problem without changing any
> API, the patch applies cleanly to libxml2 2.5.1.

  Okay, that works both for the regression tests and an hand made test:

paphio:~/XML -> cat tst.xml
<!DOCTYPE tst [
<!ENTITY a_b.ent SYSTEM "a%20b">
]>
<tst>&a_b.ent;</tst>
paphio:~/XML -> cat "a b"
hello
paphio:~/XML -> ./xmllint --noent tst.xml
<?xml version="1.0"?>
<!DOCTYPE tst [
<!ENTITY a_b.ent SYSTEM "a%20b">
]>
<tst>hello
</tst>
paphio:~/XML ->


> libxml2, there are some warning that seems to be undocumented (i.e. not
> like the absence of 'title.xml' that is previously announced) could you

  That's "normal"
> 
> Here is a small log of what I have done:
[...]
  looks good,

> Tell me if the patch may find its way in the CVS or what additional
> changes do you like to see in order to accept it.

   Applied, I just made a couple of new functions static because they
should not be exported.

> BTW you have closed the bug reported by me regarding xmlBuildURI, but
> remember that the problem isn't really solved, it's only fixed for
> absolute URIs, relative ones still suffer of the reported problem.

  Yup, but I closed the bug you reported :-)
I agree it's not a generic fix which would be quite harder to make.

Daniel

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/