Re: [xml] New FAQ suggestion - how to create a patch...

[Daniel Veillard <veillard redhat com>]

On Tue, Mar 26, 2002 at 12:28:09PM -0000, Richard Jinks wrote:
> Could I make a suggestion for a new FAQ, please?
> 
> What are the procedures for creating a patch?
> 
> I've made a couple of diff files comparing my modified files to the original
> files (using "diff -c" in cygwin).

  yep, that's the way.
To add an FAQ, modify the xml.html file which is used to produce the
site and send me the diff :-)

> Are these good enough (the output looks similar to patches you've sent out
> previously), or do I need to go through CVS (i.e. make the changes in there
> and create a diff file)?

  not needed, if you use a CVS checkout, a simple cvs -z3 diff -c will
generate the patch against the CVS bversion.

> If the latter, do I need an account to check files out in CVS?

  No, there is anonymous read only access. Check the CVs informations
pointed from the download page

> 
> Changes so far:
> I've added two new functions to trionan.c to check / set the sign of a
> double
> (VC++6 doesn't like double a=-0.0 as Bjorn suggested, so I put a function in
> to set it).
> I've also made the mods to the XPath math functions so they return -0 in the
> correct places, and does floating point mods.
> As a temporary fix, I've modified xmlXPatherror so that it doesn't report
> the filename / line number

 okay

> Still to do:
> Improve the error messages in XPath
> Work out why some NaN comparisons fail.
> Produce a more comprehensive test file / expected results file

  okay, use testXPath for the last one.

Daniel

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/