Re: [xml] XPath horribly chatty in latest release

[Daniel Veillard <veillard redhat com>]

On Fri, Mar 23, 2001 at 02:44:31PM +0000, Matt Sergeant wrote:
> Why is this?

  Could you be more precise ?
I forgot one debugging instruction but it was actually called only
if there is too many objects left on the evaluation stack after
and evaluation. If you have seen those I would be interested in
the object left and the expression tree that the instruction was dumping,
that how I will fix the code. They did not show up in my libxml nor
libxslt regression tests,

> If I turn off debug, with --without-debug, I have to apply the below patch
> to get it to compile at all.

  The actual patch to compile without debug is enclosed, but
if you have an error i would actually be interested in the debug
output,

   thanks,

Daniel

-- 
Daniel Veillard      | Red Hat Network http://redhat.com/products/network/
veillard redhat com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

Index: xpath.c
===================================================================
RCS file: /cvs/gnome/gnome-xml/xpath.c,v
retrieving revision 1.89
diff -c -r1.89 xpath.c
*** xpath.c	2001/03/19 15:58:54	1.89
--- xpath.c	2001/03/23 15:06:14
***************
*** 4457,4463 ****
   */
  xmlXPathObjectPtr
  xmlXPathConvertString(xmlXPathObjectPtr val) {
!     xmlXPathObjectPtr ret;
  
      if (val == NULL)
  	return(xmlXPathNewCString(""));
--- 4457,4463 ----
   */
  xmlXPathObjectPtr
  xmlXPathConvertString(xmlXPathObjectPtr val) {
!     xmlXPathObjectPtr ret = NULL;
  
      if (val == NULL)
  	return(xmlXPathNewCString(""));
***************
*** 5183,5189 ****
   */
  xmlXPathObjectPtr
  xmlXPathConvertNumber(xmlXPathObjectPtr val) {
!     xmlXPathObjectPtr ret;
      double res;
  
      if (val == NULL)
--- 5183,5189 ----
   */
  xmlXPathObjectPtr
  xmlXPathConvertNumber(xmlXPathObjectPtr val) {
!     xmlXPathObjectPtr ret = NULL;
      double res;
  
      if (val == NULL)
***************
*** 6463,6470 ****
  	    /*
  	     * Specific case: search a PI by name.
  	     */
- 	    xmlXPathObjectPtr cur;
- 
  	    if (name != NULL)
  		xmlFree(name);
  
--- 6463,6468 ----
***************
*** 7464,7470 ****
  	xmlGenericError(xmlGenericErrorContext,
  		"xmlXPathEval: %d object left on the stack\n",
  	        stack);
-         xmlXPathDebugDumpCompExpr(stdout, ctxt->comp, 0);
      }
      if (ctxt->error != XPATH_EXPRESSION_OK) {
  	xmlXPathFreeObject(res);
--- 7462,7467 ----