Re: [Vala] [PATCH] gtk_action_group_add_*_actions add user_data



On Wed, April 2, 2008 07:34, Jaap A. Haitsma wrote:
I've ran into an issue when using ActionGroup.add_toggle_actions or
ActionGroup.add_radio_actions. The field user_data is not being set by
the vala compiler so the C compiler complains. Attached patch should
resolve this I think. In my opinion it would be even better if the
user_data field was not there but that the vala compiler would
automatically set it to the this pointer. Is this possible?

Thanks for the patch. It looks fine, I'll merge that as soon as possible.
'this' might not always be the right choice, so I don't think we should do
that.

Also somehow I can't run vapigen on trunk for gtk+. I get an error

vapigen --library gtk+-2.0 packages/gtk+-2.0/gtk+-2.0.*
error: The type name `Gtk.FileChooserEmbed' could not be found
Generation failed: 1 error(s), 0 warning(s)

I'll look into it.

Juerg




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]