Re: [Tracker] [PATCH 00/10] Add option to show version



On 19/11/09 17:27, Juan A. Suarez Romero wrote:
On Thu, 2009-11-19 at 10:09 +0100, Philip Van Hoof wrote:
Hey Martyn,

Hej :)

I'll await the conclusions of this discussion between you and Juan
before making any changes to Juan's patches.


I don't mind either using -V or -v. So if Martyn thinks it's better to
use "-V", I'll send you a new patch that changes it.

Also, I'll try to keep up-to-date manpages.

The thing is, we have 3 applications (4 if you count tracker-writeback which we are working on) which will or do use -v to set the log verbosity. I know that when I see common command line switch patterns like this in other software, I expect it to work for all those binaries/apps. Also, -V is used by tracker-store and tracker-miner-fs. So this is more about consistency than anything for me.

But in any case, Martyn was doubting about if this option makes sense or
not. I think it makes sense, as it is an option that all programs have
(or should) have.

Yes. There is a reason for this. If _EVERY_ binary version was unique based on the changes that occurred to them, this would absolutely make sense. But as it is now, the version is ALWAYS going to be the same as the version in every other binary. So unless the user has 2 versions of tracker installed, it serves little purpose AFAICS. Now if you want it for consistency with other GNOME apps - I agree we should have it :P

I am not really dead set on one way or another, so let's include -V if that keeps everyone happy :)

So, if finally the option makes sense for you guys, I'll send an updated
version of patch. Else, feel free to revert the commit.

Yea, we should just update the short switch and man pages.

--
Regards,
Martyn



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]