Re: [Tracker] [PATCH] safe tmpfile usage

[Halton Huo <Halton Huo Sun COM>]

Hi Michael,

Does it means no comments is auto-approval? How long will be the
timeout? Then can I commit the patch for t-p?

Thanks,
Halton.
On Sat, 2007-11-24 at 02:23 +0100, Michael Biebl wrote:
> 2007/11/23, Michael Biebl <mbiebl gmail com>:
> > Hi,
> >
> > currently our (external) filter scripts are lacking resp. buggy in several ways:
> > - they don't respect the TMPDIR environment variable
> > - not safe from a security pov [1]
> > - buggy (st vs $st)
> > - unnecessary cat calls
> > - create files in $HOME (which unnecessarily get picked up by tracker)
> >
> > The attached patch addresses these issues. I used mktemp to implement
> > the creation of safe tmpfiles. TTBOMK all modern linux/solaris
> > distributions ship tool.
> > I'm posting this patch for wider review. If you know of any platform
> > (we support) that doesn't ship mktemp, please let me know.
>
> Taking no comments as approval,
> Committed as r1042.
>
> Michael
>
> Btw, this addresses https://bugs.launchpad.net/bugs/164148