Re: [Tracker] [PATCH] fixing some bad misbehavior

[jamie <jamiemcc blueyonder co uk>]

On Wed, 2007-07-25 at 00:21 +0200, Marcus Fritzsch wrote:
> Hi,
>
> On 7/24/07, jamie <jamiemcc blueyonder co uk> wrote:
> > On Tue, 2007-07-24 at 16:17 +0200, Marcus Fritzsch wrote:
> > > Hi there,
> > >
> > > as the new crawling is there I wanted to try it for my NFS exports
> > > over the net, the problem: it did not worked, the crawled directories
> > > were on the crawled directories list, but were never checked on start
> > > - this is one part.
> >
> >
> > you just need to check the crawled directories are not sub directories
> > of the watched ones and then do as you have coded.
>
> Right! Did not thought of that. And, one step further, is it a problem
> if a watched directory is a sub directory of a crawled one?
>
> The check is located in sanity_check_option_values ().


it was not right - it was much more work to do it right which I have
done!

I have corrected and applied so pls test it works ok for you

 we dont need the subdir test as we now do crawled files after watched
ones  (tracker will not reindex stuff unless the mod date has changed so
no need to worry about indexing twice and a sit uses the parent
directory last mod datetime - its efficient enough too)

also we cant delete crawled list nor remove ones that are subdirs of
watched dirs as inotify and fam need this list to filter out changes to
crawled items (we dont want to update them except at start up).

> > > The other part: when removing $HOME from WatchDirectoryRoots (also,
> > > this 'disables' the t-p preferences checkbox), $HOME is added to the
> > > watched directories if this list is empty (and so is indexed later
> > > on).
> >
> > we default to home dir if no watches set - this has been the behaviour
> > since the beginning so not sure if I want to change it
>
> Hmm, yes, but then the preferences switch for indexing and watching of
> the $HOME is pretty useless, or do I missed something here?

Have removed forced indexing of home if no watch dirs is set (default in
cfg file is home dir so should be ok)

thx

jamie