Re: [Tracker] No metadata in search results

[jamie <jamiemcc blueyonder co uk>]

On Wed, 2007-07-11 at 23:04 +0200, Laurent Aguerreche wrote:
> Le mercredi 11 juillet 2007 à 01:16 +0200, Laurent Aguerreche a écrit :
> > Le mercredi 11 juillet 2007 à 01:14 +0200, Laurent Aguerreche a écrit :
> > > Le mardi 10 juillet 2007 à 17:12 +0100, jamie a écrit :
> > > > On Tue, 2007-07-10 at 18:38 +0200, laurent aguerreche free fr wrote:
> > > > > Selon jamie <jamiemcc blueyonder co uk>:
> > > > > 
> > > > > > On Tue, 2007-07-10 at 15:29 +0200, laurent aguerreche free fr wrote:
> > > > > > > Selon jamie <jamiemcc blueyonder co uk>:
> > > > > > >
> > > > > > > > On Wed, 2007-07-04 at 02:13 -0700, Brian Davis wrote:
> > > > > > > > > Jamie, it's great to have you back. Things picked up in my life as
> > > > > > > > > well and Hum development stagnated a bit. I was cleaning up some bugs
> > > > > > > > > when I realized that the metadata issue I was whining about never
> > > > > > > > > seemed to go away for me. Any calls I make to "tracker_metadata_get()"
> > > > > > > > > return pointers to empty arrays.
> > > > > > > > >
> > > > > > > > > I'd love to find out that I'm misusing the API, but the trackerd logs
> > > > > > > > > appear to be properly extracting and returning the correct metadata.
> > > > > > > > >
> > > > > > > > > You had mentioned a few months ago that this was a known issue. Is
> > > > > > > > > there a fix in the pipeline?
> > > > > > > > >
> > > > > > > >
> > > > > > > > should be fixed in latest svn - you must reindex to see the metadata
> > > > > > > > though as the original bug occurred while indexing the data
> > > > > > > >
> > > > > > > > let me know if it solves your problems
> > > > > > >
> > > > > > > I do not see a known ReleaseDate for any of my MP3 files.
> > > > > > > tracker-extract finds it (for instance Audio:ReleaseDate=2005; on one of
> > > > > > > my musics) but tracker-search-tool doesn't.
> > > > > > >
> > > > > > > Date for a picture seems to be ignored too.
> > > > > > >
> > > > > > > Infos about when a file was created or accessed are always empty.
> > > > > > >
> > > > > >
> > > > > > ahh yes all dates need to be formatted before being stored in the key
> > > > > > cache
> > > > > >
> > > > > > will fix tonight - I knew I forgot something!
> > > > > 
> > > > > Ok.
> > > > > 
> > > > > Except that, I was looking into tracker-metadata-tile.c and I saw that we use
> > > > > SERVICE_FILES everywhere instead of SERVICE_MUSIC, SERVICE_VIDEOS, etc. Is it
> > > > > correct?
> > > > 
> > > > its not necessary because we look up the correct service to use anyhow
> > > > (so the patch is not really useful Im afraid)
> > > > 
> > > > service param is needed to determine which database to use (emails,
> > > > files and applications are stored in different dbs) so the precise
> > > > service is not needed in this case (its the same for almost all the dbus
> > > > methods that take service as a param) 
> > > 
> > > Ok.
> > > 
> > > > > I'm sending a patch to change that, I do not see any problem with it at runtime.
> > > > > The patch is very noisy because I removed empty characters at end of lines. Is
> > > > > it possible to add a script that remove these characters when we commit
> > > > > something in SVN repository or should I disable this function in my emacs
> > > > > config?
> > > > 
> > > > probably best to turn it off
> > > 
> > > Done!
> > > 
> > > > > And last, tracker-search-tool prints messages like:
> > > > >   Error : Entity with ID email://1173783021 5670 20 dohko/INBOX;uid=2512 not
> > > > > found in database
> > > > >   Entity email://1173783021 5670 20 dohko/INBOX;uid=2512 not found in database
> > > > > 
> > > > > everytime I select a mail, it looks like a wrong function is called since data
> > > > > are correctly stored in database...
> > > > 
> > > > the metadata tile does not support emails yet and thats why you get
> > > > those errors when selecting an email
> > > > 
> > > > if you have time today feel free to send a patch for supporting emails
> > > 
> > > I just begun and I already have a problem: I do not know what to call
> > > exactly...
> > > I won't have time to work on it tomorrow and perhaps until the end of
> > > the week so I think you (or someone else) should start from the few
> > > lines I added.
> > > 
> > > The patch I am sending contains cleanups:
> > > - strlen() calls to just test whether a string is empty or nor are
> > > replaced
> > > - reduces scope of some variables.
> > > 
> > > I also found a small bug with metadata printing for audio files: TST did
> > > not always print album name of a song. Fixed.
> > > 
> > 
> > And same email with attachment!
> 
> And again with a fix in is_empty_string() function.
> 
> Can I commit?

yeah sure