Re: [Tracker] Commited changes for tracked.desktop localization

[Luca Ferretti <elle uca libero it>]

Il giorno mar, 03/07/2007 alle 09.19 +0200, Michael Biebl ha scritto:
> 2007/7/3, Luca Ferretti <elle uca libero it>:
> > The file trackerd.desktop enable the launching of tracked at login.
> >
> > In gnome-session 2.19/2.20 was added the ability to show localized names
> > and comments for login-launched services. So I committed some changes to
> > enable localization for trackerd.desktop
> >
> > Now there are 3 small issues/doubts:
> >       * should we move tracked.desktop from "root" to "src/tracked" or
> >         should we add a "data" directory to put this kind of stuff?
> 
> We already have  a data/ directory!

Doh! 

> >       * could someone review and suggest better name and comment to show
> >         in gnome-session-properties dialog? [1]
> 
> What about "search and indexing service"

Good IMHO, short and clean. Jamie?

> >       * could someone check if relevant files are dist-ed?
> 
> As trackerd.in.in is already added to AC_CONFIG_FILES in configure.ac
> (for the @VERSION@ expansion), it's already put into the final tarball
> and you don't need to add it to EXTRA_DIST. As a result, you can
> remove all references to autostart_in_in_files in Makefile.am. What
> you shoud do though, is to remove trackerd.desktop aka.
> $(autostart_DATA)  in CLEANFILES.

I committed other changes this morning: trackerd.deskop is now removed
on "make clean" and trackerd.desktop.in in included in EXTRA_DIST.

Of course isn't really smart to dist something that will recreated at
configure time (.desktop.in files), but this is the behavior of other
GNOME modules.

> Btw, what about src/tracker-search-tool/tracker-search-tool.desktop.in?
> It is listed in po/POTFILES.in, yet it directly contains the
> translations. Maybe the translations should also be moved to po/*?

I've also fixed this morning both tracker-search-tool.desktop and
tracker-preferences.desktop generation. Or, at least, I hope :-)

> And what about src/tracker-preferences/tracker-preferences.desktop.in:
> We don't specify the X-GNOME-Bugzilla-Version= VERSION@ etc. stuff
> there, as we do for trackerd.desktop and tracker-search-tool. This
> should be unified imho.

I'm adding X-GNOME-*. I've also changed StartupNotify and fixed Icon
keys. I still have to check is Categories key is ok.

> Luca, can you take a look at that or shall I prepare patches?

Should be fixed on svn. Check it out, maybe there are still some pending
stuff/issue

Cheers, Luca.