Re: [Tracker] Patch for Evolution



Le dimanche 01 juillet 2007 Ã 00:11 +0100, jamie a Ãcrit :
On Sun, 2007-05-13 at 19:48 +0200, Laurent Aguerreche wrote:
Hello,

I send a patch for Evolution.

* indexing of more emails with imap. Some emails are named/stocked that
way:
  - id_mail.HEADER
  - id_mail.1.MIME
  - id_mail.1
  - id_mail.2.MIME
  - id_mail.2
  - etc.
  where *.MIME contains MIME type of corresponding mail part. So with
this schema body mail is in first mail part and other parts are assumed
to contain mail attachments.

* fix bad parsing of summary file:
   in skip_token(), '>=' and not '>' to test return of fseek()
* all 'char' switched to 'gchar' (and same thing for 'int')


For all email module:
* use of g_slice_new0/g_slice_free to (des)allocate email-related
structures.

I committed this but not sure about using some of the gmime functions -
I originally replaced some of them as they left open file handles (1024
limit on linux) which means email indeixng will fail. Hopefully your
patch is ok here but I may have to remove some of it if file handle
problems arise

Everyone else can you test email indexing is working ok especially with
large number of attachments

If I remember correctly I fixed that bug some weeks ago with magic on some gmime
functions calls. Now I do not see any problems with "lsof | grep -i trackerd".

But I see a lot of errors about PRIMARY KEYS like :

01 jui 2007, 02:43:25:915 -
Indexing /local/laguerre/.evolution/mail/imap/laurent aguerreche imap free fr/system with service Folders and 
mime Folder (new)
01 jui 2007, 02:43:25:916 - service id for Folders is 3 and sid is 6
with mime Folder
01 jui 2007, 02:43:25:916 - ERROR : execution of prepared query
CreateService failed due to PRIMARY KEY must be unique with return code
1

and I do not really know how to fix that.


I am sending a patch that fix a bad parsing of some evolution mime
files. This bug makes trackerd crashing!
This patch also contains some work for KMail but since I did that some
weeks ago I do know remember exactly current state of code and so I
prefer to keep KMail's emails indexing disabled.


The patch contains a lot of noise because I forgot to turn off
systematical removal of empty characters at end of lines in emacs...


Laurent.


jamie


Attachment: fix-evo-mime-files-parsing.patch.gz
Description: GNU Zip compressed data

Attachment: signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]