Re: [Tracker] 2 deskbar handler versions in one file

["Michael Biebl" <mbiebl gmail com>]

2007/8/13, Marcus Fritzsch <fritschy googlemail com>:
> Hey there.
>
> It's already late - I succeeded at getting 2 deskbar version handlers
> into one .py - the problem is, the code is rather ugly, just by
> multiple inheritance the problem is not solved, one needs
> Implementation classes that wrap the actual work.
>
> I don't know if this one is better suited, it certainly gets us away
> from those '2 handlers'. The other benefit from that, fixes and
> updates to one handler may automagically work also for the second one
> (as i had to port my recent changes from handler1 to handler2).

Looks good to me. You share over 50% of the code between the two
versions, so I really think it's a benefit to keep the two versions in
one single handler.
It also means less/no work for me, so I'm all happy ;-)
No configure changes, no changes to the debs, easier upgrade paths.

The only remaining issue might be, that the new deskbar-applet might
actually get versioned install dirs for the handlers, as jamie
mentioned.
If this is the case, we are almost back to the beginning, as we need a
configure check, adapt the install path in the makefile.am accordingly
etc.
It would be good to have a definitive answer from upstream about that
matter, before we decide which way to go.

Cheers,
Michael



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?