Re: [Tracker] [PATCH] Make tracker skip mountpoints



On Mon, 2007-08-06 at 04:03 +0200, Marcus Fritzsch wrote:
This patch prevents tracker from descending into mountpoints which is
a directory other than a watch- or crawl-root. I often have some fs
(sshfs, nfs) mounted under my $HOME and found tracker going down all
these trees. Also, there was a bug report on launchpad about this[1].

I am however not sure if this method works, also I haven't found much
references when searching for it by google or clusty. If there are
objections to this method of mount-point 'discovery' it would be
possible to read mtab and store it in struct Tracker for processing.

However as tracker is not that simple I am not aware of any side
effects this patch may have on tracker, I tested it - with mount
points in watched dirs and crawled ones, with fuse and nfs mounts.

Any comments?


yeah its a good idea

but take a look at tracker-utils.c:

tracker_file_is_no_watched
tracker_file_is_crawled


would be nice to have a tracker_file_is_mounted and then call it where
you have the code

also by default, we want to index everything so omitting mounted stuff
should be an option in tracker.cfg and in tracker-preferences but be off
by default - are you ok to amend these?

will apply once done

jamie





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]