Re: [Tracker] invalid field causes trackerd to quit

["Ulrik Mikaelsson" <ulrik mikaelsson gmail com>]

Hmm, the punishment of incorporating my patches is getting more of them. ;)

Here's one that does the following;

* Fixes the mentioned field-checking issue.
* Fixes an issue with the symptoms that when you call GetMetadataForFilesInFolder(-1, <aFolder>, <aString>), tracker chews up all the memory and dies.
 + This issue is probably present in just about all the functions of this file, and is fixed for this file. (Not other dbus-interfaces, though. It's a lot of boring work to deal with error-handling.)
* Fixes a memory-leak in GetMetadataForFilesInFolder, where the string array of the message were not free:d as mentioned in 
http://dbus.freedesktop.org/doc/api/html/group__DBusMessage.html#gaa5e339a728a7baa786e6c30e3b840b7

Please check this out, and see if it's of any use to you.

Regards
/ Ulrik

On 10/19/06, Jamie McCracken <jamiemcc blueyonder co uk> wrote:

Peter Rullmann wrote:
> Hi,
>
> when I call Files.GetMetadataForFilesInFolder with an invalid field
> (like "name" instead of "File.Name"), trackerd shuts down quietly.
>
> Example in Ruby:
> reply = files_interface.GetMetadataForFilesInFolder(-1,
> "/home/peterpan/Desktop", ["name"])
>
> The DBus bindings I'm using (QtRuby for Qt4.2) are not yet well testet
> so it might be due to these bindings. But trackerd shouldn't crash
> whatever input it gets.
>
> I guess there are some argument checks missing.
>

possibly - will look at this this weekend. Thanks for the info.

--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/

_______________________________________________
tracker-list mailing list
tracker-list gnome org
http://mail.gnome.org/mailman/listinfo/tracker-list

Attachment: tracker-dbus-fixes.patch
Description: Text Data