Re: Some code changes wanted in Rygel

[Kjartan Maraas <kmaraas broadpark no>]

sø., 26.09.2010 kl. 23.52 +0300, skrev Zeeshan Ali (Khattak):
> Hi,
> 
> On Sun, Sep 26, 2010 at 11:28 PM, Kjartan Maraas <kmaraas broadpark no> wrote:
> > sø., 26.09.2010 kl. 23.12 +0300, skrev Zeeshan Ali (Khattak):
> >> Hi dear release team,
> >>    Before I make the 0.8.0 release of Rygel tomorrow for GNOME 2.32.0,
> >> I would like to merge the following range of changes from git master
> >> that fixes some important issues:
> >>
> >> 206f01926d3293d4885c69d090467270f28a36c3..f0b0127c3227848ab73ad4c17feef90acc80eb83
> >>
> > Looking at the diff most of this looks straight forward, but the file
> > renaming makes the diff unmanagable for me. Could you explain them in
> > plain words instead to make it easier?
> >
> > Some of it seems to be a move to use intltool which is a good thing, but
> > the other xml files I don't know right away what to think about.
> 
>   All these changes are to fix these 2 bugs:
> 
> https://bugzilla.gnome.org/show_bug.cgi?id=626196
> https://bugzilla.gnome.org/show_bug.cgi?id=629378 (this patch was
> reviewed by Andre Klapper for me).
> 

Then I guess it's the first of those I don't really understand yet. What
do the XML files do? Configuration for various models? Define some
protocol to talk with them? What does the change to them do? What are
the risks involved in approving this patch?

Just some more info to make it easier for the release team to make a
decision :-)

Cheers
Kjartan