Re: freeze break request for glibmm

["Jonathon Jongsma" <jonathon quotidian org>]

On 3/7/08, Kjartan Maraas <kmaraas broadpark no> wrote:
> fr., 07.03.2008 kl. 13.28 -0600, skrev Jonathon Jongsma:
>
> > I just noticed that there is a missing include in the main glibmm
>  > header <glibmm.h>.  The following patch describes the fix.  Is it ok
>  > to break the code freeze to apply?  Thanks.
>  >
>  > Index: glib/glibmm.h
>  > ===================================================================
>  > --- glib/glibmm.h     (revision 637)
>  > +++ glib/glibmm.h     (working copy)
>  > @@ -25,6 +25,7 @@
>  >  #include <glibmmconfig.h>
>  >  //#include <glibmm/i18n.h> //This must be included by the
>  > application, after system headers such as <iostream>.
>  >  #include <glibmm/arrayhandle.h>
>  > +#include <glibmm/checksum.h>
>  >  #include <glibmm/class.h>
>  >  #include <glibmm/containerhandle_shared.h>
>  >  #include <glibmm/convert.h>
>  >
>
> I think build fixes are allowed at any time. Thanks for asking though.

In this case, this isn't a build fix per se.  glibmm builds fine
without it.  But if anybody tries to develop an application using
glibmm and just includes <glibmm.h> thinking they'll get all of the
includes, their application won't have the Checksum definitions.
They'll still be able to work around it by including the checksum
header directly of course.  In any case, can I assume that's 2
approvals? :)

-- 
jonner