Re: code changes request



>
> Hi,
>
> There are two changes that we want to make in Gnopernicus. One of them
> is related on bug http://bugzilla.gnome.org/show_bug.cgi?id=314824, some
> strings are not marked correctly for translation and this causes a
> problem _ONLY_ when brltty is installed (brltty is not installed by
> default). A compilation break appears _ONLY_ when brltty is installed.

Build fixes don't need approval.

> Our intention was to mark the strings for translation.
> The other thing is related on bug
> http://bugzilla.gnome.org/show_bug.cgi?id=314924. The attached patch for
> this bug introduces a modification _ONLY_ for test files, because the
> tests didn't work well. The main modification is: the type of an
> argument passed to a function is changed from 'int to 'char*'. The
> modification is made so that everything work and the impact of this
> modification upon the product is zero.
> We request your approval to made these changes in Gnopernicus.

I think modifications to test cases fall under build fixes too. Please go
ahead.

Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]