Re: [MM] Problem Huawei E303

[Aleksander Morgado <aleksander lanedo com>]

> Now the Modem Manager always detects the Huawei e303. :)
>
> But with this version I have a compilation warning.
> I get the next error:
>
> make[3]: Entering directory `/home/jose/modemmanager/ModemManager/src'
>   CC       ModemManager-mm-plugin.o
> mm-plugin.c: In function ‘mm_plugin_supports_port’:
> mm-plugin.c:753:20: error: ‘probe’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> cc1: all warnings being treated as errors
> make[3]: *** [ModemManager-mm-plugin.o] Error 1
> make[3]: Leaving directory `/home/jose/modemmanager/ModemManager/src'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/jose/modemmanager/ModemManager/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/jose/modemmanager/ModemManager'
> make: *** [all] Error 2
>
>
> I have solved it by asigning a NULL value to probe on startup, but I don't know if that is the propper way 
> to fix it:
>
> index 4616e9d..06efc2d 100644
> --- a/src/mm-plugin.c
> +++ b/src/mm-plugin.c
> @@ -629,7 +629,7 @@ mm_plugin_supports_port (MMPlugin *self,
>                           GAsyncReadyCallback callback,
>                           gpointer user_data)
>  {
> -    MMPortProbe *probe;
> +    MMPortProbe *probe = NULL;
>      GSimpleAsyncResult *async_result;
>      PortProbeRunContext *ctx;
>      gboolean need_vendor_probing;

Almost :)

Pushed a fix for this already.

Cheers!

-- 
Aleksander