nmcli assertions with bridging patches

[Thomas Goetz <thomas goetz citrix com>]

I found the source of the error in my previous message (quoted below). It comes from this part of bridge patch 5:

--- a/libnm-glib/nm-device.c
+++ b/libnm-glib/nm-device.c
@@ -217,6 +217,8 @@ _nm_device_gtype_from_dtype (NMDeviceType dtype)
 		return NM_TYPE_DEVICE_BOND;
 	case NM_DEVICE_TYPE_VLAN:
 		return NM_TYPE_DEVICE_VLAN;
+	case NM_DEVICE_TYPE_BRIDGE:
+		return NM_DEVICE_TYPE_BRIDGE;
 	default:
 		g_warning ("Unknown device type %d", dtype);
 		return G_TYPE_INVALID;

For reference, here is the version of the bridge patch I used: https://mail.gnome.org/archives/networkmanager-list/2012-May/msg00060.html

Here is the delta patch:

diff --git a/libnm-glib/nm-device.c b/libnm-glib/nm-device.c
index eaf2e3b..7d768ed 100644
--- a/libnm-glib/nm-device.c
+++ b/libnm-glib/nm-device.c
@@ -35,6 +35,7 @@
 #include "nm-device-infiniband.h"
 #include "nm-device-bond.h"
 #include "nm-device-vlan.h"
+#include "nm-device-bridge.h"
 #include "nm-device.h"
 #include "nm-device-private.h"
 #include "nm-object-private.h"
@@ -219,7 +220,7 @@ _nm_device_gtype_from_dtype (NMDeviceType dtype)
        case NM_DEVICE_TYPE_VLAN:
                return NM_TYPE_DEVICE_VLAN;
        case NM_DEVICE_TYPE_BRIDGE:
-               return NM_DEVICE_TYPE_BRIDGE;
+               return NM_TYPE_DEVICE_BRIDGE;
        default:
                g_warning ("Unknown device type %d", dtype);
                return G_TYPE_INVALID;

> I'm getting crashes and assertions form nmcli with network manager and libnm built with the bridging patches. It happens when trying to construct a bridge object. The rebuild libnm is installed on the target. I'm assuming this has to do with a the new bridge type not being registered properly with glib. Can anyone provide more information?
> 
> 
> Assertion, stack text, and function where it dies:
> 
> Starting program: /usr/bin/nmcli con
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
> 
> (process:9778): GLib-GObject-CRITICAL **: g_object_new: assertion `G_TYPE_IS_OBJECT (object_type)' failed
> 
> (process:9778): GLib-GIO-CRITICAL **: g_initable_init: assertion `G_IS_INITABLE (initable)' failed
> 
> (process:9778): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed
> 
>