Am 19.03.2011 20:16, schrieb Dan Williams: > VPN plugins to follow. Thanks to everyone so far for their testing, > lets keep at it til we're done. 1/ The network-manager tarball has a build-aux directory, which contains compile config.guess config.rpath config.sub depcomp install-sh ltmain.sh missing The same file are also available in the root directory. This is 436K of duplicated data. build-aux is used because of AC_CONFIG_AUX_DIR([build-aux]). I haven't further investigated yet, if that macro does not work as expected. 2/ We should only ship the input files for the SysV init scripts in the tarball, not the generated files. Patch attached. 3/ introspection/nm-device-cdma.xml, nm-device-gsm.xml and src/nm-gsm-device.h are in Git, but not the tarball. This seems to be because of 2140dad5e0de0033e5c9bb10bd77ecd80085e5a3 Should those files be removed from Git? 4/ What is src/ppp-manager/nm-pppd-plugin.xml good for (in Git)? It doesn't seem to be used is not part of the dist tarball 5/ Missing tests/test files in tarball src/settings/plugins/ifcfg-rh/tests/iscsiadm-test-bad-entry src/settings/plugins/ifcfg-rh/tests/iscsiadm-test-bad-record test/add-connection.py (unused?) test/nm-dhcp-opt-test.c (unused?) test/nmnetlinktest.c (unused?) test/set-hostname.py (unused?) Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
From b8645ed168998fd9a249b8e692ff85d76bef5f35 Mon Sep 17 00:00:00 2001 From: Michael Biebl <biebl debian org> Date: Sun, 20 Mar 2011 10:23:02 +0100 Subject: [PATCH] Only ship input files for SysV init scripts in dist tarball Not the generated files. --- initscript/Arch/Makefile.am | 2 +- initscript/Gentoo/Makefile.am | 2 +- initscript/Mandriva/Makefile.am | 2 +- initscript/RedHat/Makefile.am | 2 +- initscript/Slackware/Makefile.am | 2 +- initscript/linexa/Makefile.am | 2 +- initscript/paldo/Makefile.am | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/initscript/Arch/Makefile.am b/initscript/Arch/Makefile.am index 2c1f8b5..0be1bc2 100644 --- a/initscript/Arch/Makefile.am +++ b/initscript/Arch/Makefile.am @@ -1,4 +1,4 @@ -EXTRA_DIST = networkmanager +EXTRA_DIST = networkmanager.in DISTCLEANFILES = networkmanager initddir = $(sysconfdir)/rc.d diff --git a/initscript/Gentoo/Makefile.am b/initscript/Gentoo/Makefile.am index af023b7..890ed77 100644 --- a/initscript/Gentoo/Makefile.am +++ b/initscript/Gentoo/Makefile.am @@ -1,4 +1,4 @@ -EXTRA_DIST = NetworkManager +EXTRA_DIST = NetworkManager.in DISTCLEANFILES = NetworkManager initddir = $(sysconfdir)/init.d diff --git a/initscript/Mandriva/Makefile.am b/initscript/Mandriva/Makefile.am index 0a0cc2b..09277de 100644 --- a/initscript/Mandriva/Makefile.am +++ b/initscript/Mandriva/Makefile.am @@ -1,4 +1,4 @@ -EXTRA_DIST = networkmanager +EXTRA_DIST = networkmanager.in DISTCLEANFILES = networkmanager initddir = $(sysconfdir)/rc.d/init.d diff --git a/initscript/RedHat/Makefile.am b/initscript/RedHat/Makefile.am index 3f7b876..347d0fa 100644 --- a/initscript/RedHat/Makefile.am +++ b/initscript/RedHat/Makefile.am @@ -1,4 +1,4 @@ -EXTRA_DIST = NetworkManager +EXTRA_DIST = NetworkManager.in DISTCLEANFILES = NetworkManager initddir = $(sysconfdir)/rc.d/init.d diff --git a/initscript/Slackware/Makefile.am b/initscript/Slackware/Makefile.am index ded3ee0..8fce2cf 100644 --- a/initscript/Slackware/Makefile.am +++ b/initscript/Slackware/Makefile.am @@ -1,4 +1,4 @@ -EXTRA_DIST = rc.networkmanager +EXTRA_DIST = rc.networkmanager.in DISTCLEANFILES = rc.networkmanager initddir = $(sysconfdir)/rc.d diff --git a/initscript/linexa/Makefile.am b/initscript/linexa/Makefile.am index 0a0cc2b..09277de 100644 --- a/initscript/linexa/Makefile.am +++ b/initscript/linexa/Makefile.am @@ -1,4 +1,4 @@ -EXTRA_DIST = networkmanager +EXTRA_DIST = networkmanager.in DISTCLEANFILES = networkmanager initddir = $(sysconfdir)/rc.d/init.d diff --git a/initscript/paldo/Makefile.am b/initscript/paldo/Makefile.am index 3d67ff6..22d2e31 100644 --- a/initscript/paldo/Makefile.am +++ b/initscript/paldo/Makefile.am @@ -1,4 +1,4 @@ -EXTRA_DIST = NetworkManager +EXTRA_DIST = NetworkManager.in DISTCLEANFILES = NetworkManager initddir = $(sysconfdir)/init.d -- 1.7.4.1
Attachment:
signature.asc
Description: OpenPGP digital signature