org.freedesktop.ModemManager.Modem.Gsm.Network.NetworkMode signal



Hola,

I think that Network.NetworkMode's enum has some values that should be
changed to something more realistic. The devices I have around (Option
and Huawei mainly) won't emit an 'ANY' signal, neither a 'PREFER_2G',
ditto with 'PREFER_3G'. I propose to change it to:

MM_MODEM_GSM_NETWORK_MODE_NO = 0 # NO SIGNAL
MM_MODEM_GSM_NETWORK_MODE_GPRS = 1
MM_MODEM_GSM_NETWORK_MODE_EDGE = 2
MM_MODEM_GSM_NETWORK_MODE_3G = 3
MM_MODEM_GSM_NETWORK_MODE_HSDPA = 4
MM_MODEM_GSM_NETWORK_MODE_HSUPA = 5
MM_MODEM_GSM_NETWORK_MODE_HSPA = 6

If the last three members seem to much info they could be marged into
a "3G+" although I prefer granularity and exactness :)

Regards,

-- 
Pablo Martí
http://www.linkedin.com/in/pmarti || http://www.warp.es
python -c "print '706d6172746940776172702e6573'.decode('hex')"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]