Re: nm-connection-editor crash when adding or deleting vpn connection

[Dan Williams <dcbw redhat com>]

On Tue, 2008-09-23 at 18:22 +0300, Tambet Ingo wrote:
> On Tue, Sep 23, 2008 at 11:36 AM, Tambet Ingo <tambet gmail com> wrote:
> > On Tue, Sep 23, 2008 at 5:51 AM, Bin Li <libin charles gmail com> wrote:
> >> Yes, I've update the NM r4088 and applet r899, when I adding the
> >> openvpn configuration in nm-connection-editor, it same issue. And
> >> start again nm-connection-editor, you could found the configuration
> >> already be added. When you delete this configuration, it prompt:
> >>
> >> ** (nm-applet:24554): WARNING **: nma_gconf_connection_changed:
> >> Invalid connection /system/networking/connections/10:
> >> 'NMSettingIP4Config' / 'method' invalid: 2
> >> Segmentation fault
> >
> > The warning isn't directly related to the crash. It crashes because
> > openvpn plugin does not implement "delete_connection" and
> > "save_secrets" methods. It would be an easy fix to just not make it
> > crash, but while looking into it, I remembered something else I had
> > meant to take care of: openvpn properties page does not have any way
> > of setting passwords.
> >
> > I'm on it and will post a patch later today.
> 
> Attached. Some good person should add "Show passwords" checkboxes to
> all the openvpn connection method tabs too. :)

Thanks, please commit.

Dan