[patch] gsm modem with pin active

["Eddi De Pieri" <eddi depieri net>]

I've a gsm modem that don't work with nm.

The problem is the actual init string don't work with my modem until it accepts the pin code. (look at ubuntu bug)

 

Actually nm-gsm-device, send 2 times "ATZ E0 V1 X4 &C1 +FCLASS=0".

 

With my patch, it send:

 

ATZ,

AT+CPIN=1234 if needed

finally

ATZ E0 V1 X4 &C1 +FCLASS=0

 

I think this approch is more generic, but need some regression with other modem with pin active.

 

Regards

 

https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/290177

 

http://launchpadlibrarian.net/19430481/nm-gsm-device.c.patch

 

--- nm-gsm-device.c.orig	2008-10-20 16:22:58.000000000 +0200
+++ nm-gsm-device.c	2008-11-06 17:14:06.000000000 +0100
@@ -582,7 +582,7 @@
 {
 	switch (reply_index) {
 	case 0:
-		power_up (NM_GSM_DEVICE (device));
+		init_modem_full (NM_GSM_DEVICE (device));
 		break;
 	case 1:
 		enter_pin (NM_GSM_DEVICE (device), NM_GSM_SECRET_PIN, FALSE);
@@ -644,7 +644,7 @@
 {
 	const char *responses[] = { "OK", "ERROR", "ERR", NULL };
 
-	modem_wait_for_reply (NM_GSM_DEVICE (device), "ATZ E0 V1 X4 &C1 +FCLASS=0", 10, responses, responses, init_done, NULL);
+	modem_wait_for_reply (NM_GSM_DEVICE (device), "ATZ", 10, responses, responses, init_done, NULL);
 }
 
 static NMActStageReturn