Re: [jokosher-devel] [PATCH] Tooltips for most of the interface

[Laszlo Pandy <laszlok2 gmail com>]

Adam Reid wrote:
> Hello all,
>
> This is my first patch ever for any project, but I love what you guys
> are doing so I thought I'd help where I can.
>
> This patch contains tooltips for almost everything.  

Wow, impressive. :)

> Things I haven't
> done yet are the balance sliders, zoom sliders, and context sensitivity
> for the workspace button.  I can't quite wrap my head around how to
> manipulate the widget properties from the wTree.

Its simple. Just do self.wTree.get_widget("thewidgetname"), where the 
widget's name is the name given in the glade file. That function call 
returns the instance of the gtk widget that was created when the gui was 
loaded by libglade. Say I wanted to change tset the tooltip on a 
gtk.Label that was in the glade file:

self.mylabel = self.wTree.get_widget("mylabel")
labeltip = gtk.Tooltips()
labeltip.set_tip(self.mylabel, _("Turn click track on"), None)


> Let me know if there are any problems with this patch or if I missed
> other things.

Ya, just one thing. See below.

> Index: Jokosher/JokosherApp.py
> ===================================================================
> --- Jokosher/JokosherApp.py	(revision 851)
> +++ Jokosher/JokosherApp.py	(working copy)
> @@ -37,7 +37,9 @@
>  		gtk.glade.textdomain(Globals.LOCALE_APP)
>  		
>  		self.wTree = gtk.glade.XML(Globals.GLADE_PATH, "MainWindow")
> -		
> +		def printTree():
> +			for widget in wTree:
> +				print widget

Is the function printTree() supposed to be there? I really don't think 
so, and even if it should be there, it shouldn't be printing to the 
console. We use Globals.debug() instead.

Since Jono already committed your patch unchanged, I will blame him for 
the lack of quality control in his patch review.

Thanks for the patch adam!

Laszlo