Re: Removal of warnings from layoutline.h

[Murray Cumming <murrayc murrayc com>]

On Tue, 2008-01-08 at 20:27 -0500, JLM wrote:
> I'm working on an application that uses gtkmm. I compile my application
> with full warnings on. I'd like the application to compile completely
> silently. I noticed a warning with
> 
> /usr/include/pangomm-1.4/pangomm/layoutline.h
> 
> /usr/include/pangomm-1.4/pangomm/layoutline.h:238: warning: redundant
> redeclaration of 'Glib::RefPtr<Pango::LayoutLine>
> Glib::wrap(PangoLayoutLine*, bool)' in same scope
> /usr/include/pangomm-1.4/pangomm/layoutline.h:200: warning: previous
> declaration of 'Glib::RefPtr<Pango::LayoutLine>
> Glib::wrap(PangoLayoutLine*, bool)'
> 
> Is there any reason to have two declarations of this function? Below is
> a patch that removes one of the declarations, and puts the doxygen
> comments on the first declaration. I hope this can be accepted.

What compiler is this? What warnings option are you using?

The comment in the code says:

// forward declaration needed by LayoutLineTraits
Glib::RefPtr<Pango::LayoutLine> wrap(PangoLayoutLine* object, bool
take_copy /* = false */);

It's a little difficult to remove the second declaration, because it's
generated by gmmproc, but I guess we can find a way if it's really
necessary.

If you have a patch against svn then please do attach it to a bugzilla
bug.

-- 
murrayc murrayc com
www.murrayc.com
www.openismus.com