Re: [gtk-vnc-devel] [PATCH][RFC] Support for ExtendedKeyEvent client message

[Anthony Liguori <anthony codemonkey ws>]

Daniel P. Berrange wrote:
> On Sat, Jan 12, 2008 at 06:42:41PM -0600, Anthony Liguori wrote:
>   
> > I've included both the gtk-vnc patch and the QEMU patch.  I'd like to 
> > apply the gtk-vnc one before submitting the QEMU one so please review.  
> > I'm pretty sure I've got it right.
> >     
>
> It looks reasonable to me. I'm going to forward it to Markus Armbruster
> too, to see what he thinks about it. We've wondered about similar idea
> for the Xen Paravirt framebuffer for a while now.5D..
>   

I am thinking of making one change.  Right now, we pass X key code and 
convert to PC key codes within QEMU.  I think it would make more sense 
to do that conversion and gtk-vnc and define the protocol such that PC 
key codes were passed.  I believe that Windows provides PC key codes 
directly so this seems to make sense to me.

Regards,

Anthony Liguori

> Dan.
>