Re: PATCH: Perl-cairo: Add bindings for PDF outline support



On 05.11.20 02:19, Raymond S Brand wrote:
Perl-cairo patch to add bindings for PDF outline support.

Looks good, especially since you've included docs and unit tests!

This patch is technically incomplete since I don't know how the
following defined constants should be handled. Constructive suggestion
welcome.

     CAIRO_PDF_OUTLINE_ROOT    # 0
     CAIRO_TAG_DEST        # 'cairo.dest'
     CAIRO_TAG_LINK        # 'Link'

I'd suggest using newCONSTSUB as in <https://stackoverflow.com/a/57680233>.

Do you want to include such a change with this patch or should I go
ahead and apply it as is for now?

-Torsten


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]