Re: gperl_callback_invoke userdata copy



Torsten Schoenfeld wrote:
The patch looks good to me, except for this bit:

+                     SvREFCNT_inc_simple_void_NN (data);
+                     XPUSHs (sv_2mortal (data));

Why not this instead?

                      XPUSHs (sv_2mortal (SvREFCNT_inc (data)));

Committed with this.  Thanks!

-Torsten



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]