Re: Gtk2 1.160 build errors

[Torsten Schoenfeld <kaffeetisch gmx de>]

On Mon, 2007-10-29 at 14:24 +0100, Jeffrey Ratcliffe wrote:
> On 18/10/2007, Torsten Schoenfeld <kaffeetisch gmx de> wrote:
> > > ... SO ...  that code *should* be fine.  Some parens wouldn't hurt
> > > (e.g.,  my $func = ($flags & 'value') ? 'signal_connect_after' :
> > > 'signal_connect';) but should not be necessary...  unless the
> > > particular version of the perl interpreter used by the original
> > > poster is somehow misparsing the line.
> 
> Just for confirmation - with this RHEL 4 box running Perl 5.8.5, I see
> the same build failure, fixed by replacing qw/after/ with 'after'.

OK then.  I just committed the attached patch to both branches.  Thanks
for tracking this down.

-- 
Bye,
-Torsten

Index: Gtk2.pm
===================================================================
RCS file: /cvsroot/gtk2-perl/gtk2-perl-xs/Gtk2/Gtk2.pm,v
retrieving revision 1.111
diff -u -d -p -r1.111 Gtk2.pm
--- Gtk2.pm	28 Oct 2007 23:18:30 -0000	1.111
+++ Gtk2.pm	30 Oct 2007 20:07:45 -0000
@@ -128,7 +128,7 @@ sub _do_connect {
       $flags,
       $handler) = @_;
 
-  my $func = $flags & qw/after/ ? 'signal_connect_after' : 'signal_connect';
+  my $func = ($flags & 'after') ? 'signal_connect_after' : 'signal_connect';
 
   # we get connect_object when we're supposed to call
   # signal_connect_object, which ensures that the data (an object)