[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Setting a RadioItem created with ItemFactory



hi Torsten;

On Fri, 2007-01-05 at 00:24 +0100, Torsten Schoenfeld wrote:
> On Thu, 2007-01-04 at 23:03 +0000, Emmanuele Bassi wrote:
> 
> > > hmm.  we should really add a marker in the apidoc generator for
> > > deprecated objects.
> 
> Good idea!  The patches look fine to me except for two things:
> 
> * I think it should be "deprecated by" instead of "deprecated for".

right.

> * You're using spaces for indention whereas the surrounding code uses
> tabs.  Thus, at least with a tab width of 8, the code doesn't line up.

yeah, I noticed that when looking at the attachment in the archives;
I'll redo the patch using tabs before committing, even though tabs are
most evil. ;-)

ciao,
 Emmanuele.

-- 
Emmanuele Bassi,  E: ebassi gmail com
W: http://www.emmanuelebassi.net
B: http://log.emmanuelebassi.net




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]