Re: src.rpm for x86_64



On Wed, 2004-10-20 at 16:18, Carl Nygard wrote:
One more time...

Now that I browsed through the /usr/lib/rpm/x86_64-linux/macros file, I
see the following definition:

%__os_install_post    \
    /usr/lib/rpm/brp-compress \
    /usr/lib/rpm/brp-strip \
    /usr/lib/rpm/brp-strip-static-archive \
    /usr/lib/rpm/brp-strip-comment-note \
%{nil}
                                                                                
This tell me where the brp-compress is coming from.  It also indicates
that it's probably not so bad to hardcode the path to brp-compress,
since that's hardcoded in the ./rpm/<platform>-linux/macros file.

So I propose the following patch instead:

-[ -x %{_libdir}/rpm/brp-compress ] && %{_libdir}/rpm/brp-compress
+[ -x /usr/lib/rpm/brp-compress ] && /usr/lib/rpm/brp-compress

This seems to work on x86_64, and I'd assume it works on i386, since the
path is hardcoded in ./rpm/i[3456]86-linux/macros as well.

have you looked at any of the spec files for working perl srpms on
x68_64. i'm looking around for what other (official) fedora rpms are
doing and found this:

[ -x /usr/lib/rpm/brp-compress ] && /usr/lib/rpm/brp-compress

looks familiar, huh? the same rpm is in their i386 and x86_64 dirs. i'm
going to look around a bit more and see what else is different in there
and then make the changes throughout our trees. i don't think these will
be worth doing a set of rels for, but i might be talked into doing .2
rpms.

If you want me to generate real patches for all the spec.in files, I can
do that as well.  But I'm betting they will all be the same boilerplate
fix.

that shouldn't be necessary, but i want to be careful with whatever fix
we end up doing. i want to do a bit more investigation before we go
through and fix them all.

-- 
-rm
http://www.neces.com/




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]