[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[PATCH] fix broken api of Gtk2::TreeSelection->get_selected() [gtk2-perl regression]



this patch fix the broken api of Gtk2::TreeSelection->get_selected()

unlike C and gtk2-perl APIs, Gtk2::TreeSelection->get_selected()
return its return values in the wrong order.

--- ./xs/GtkTreeSelection.xs.tv1	2003-07-05 15:12:29.000000000 +0200
+++ ./xs/GtkTreeSelection.xs	2003-07-05 15:13:48.000000000 +0200
@@ -91,9 +91,8 @@
     PPCODE:
 	if (!gtk_tree_selection_get_selected (selection, &model, &iter))
 		XSRETURN_EMPTY;
+	XPUSHs (sv_2mortal (newSVGtkTreeModel (model)));
 	XPUSHs (sv_2mortal (newSVGtkTreeIter_copy (&iter)));
-	if (GIMME_V == G_ARRAY)
-		XPUSHs (sv_2mortal (newSVGtkTreeModel (model)));
 
 #if GTK_CHECK_VERSION(2,2,0)
 
so it's both wrong and a regression from inline tree of gtk2-perl


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]