Re: Grilo + Spotify



On Thu, 2011-01-06 at 14:59 +0000, Fabien Lebaillif - Delamare wrote:
> Hi, 
> 
> I am writing a grilo plugin to support Spotify.
> 
> http://www.spotify.com
> 

Hey! That's reeeally cool!

> As for youtube and others the plugin requires several configuration
> options (username, password, spotify application key).
> 
> Would it be acceptable to add some config key or is there a more
> appropriate way to pass those information to the plugin.
> 
> The config keys would be as follow :
> GRL_CONFIG_KEY_USERNAME as a string
> GRL_CONFIG_KEY_PASSWORD as a string

I think these keys make sense in for other plugins too.

> GRL_CONFIG_KEY_APIKEY_BLOB as an array of byte ( spotify requires a
> binary api key)
> 

Right now, config keys are mostly strings.

Also, current approach is a bit rigid, and we should rethink it to use a
similar approach as metadata keys.


> If this is accepable I will provide a patch.

In any case, patch is welcome.

	J.A.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]