[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[PATCH] libgoffice should doesn't pass correct type to gsf_xml_gvalue_from_str()
- From: Christian Neumair <cneumair gnome org>
- To: gnumeric-list <gnumeric-list gnome org>
- Subject: [PATCH] libgoffice should doesn't pass correct type to gsf_xml_gvalue_from_str()
- Date: Fri, 10 Aug 2007 16:21:05 +0200
gsf_xml_gvalue_from_str() must know the precise type for G_TYPE_ENUM-
and G_TYPE_FLAGS-derived types, and not just its fundamental type. Thus,
goffice shouldn't pass the fundamental type but the actual object type
to gsf_xml_gvalue_from_str(). Otherwise, libgsf can't read enums and
flags from XML files.
Proposed patch attached.
--
Christian Neumair <cneumair gnome org>
Index: goffice/graph/gog-object-xml.c
===================================================================
--- goffice/graph/gog-object-xml.c (Revision 1789)
+++ goffice/graph/gog-object-xml.c (Arbeitskopie)
@@ -539,7 +539,7 @@ gogo_prop_end (GsfXMLIn *xin, G_GNUC_UNU
return;
}
- if (!gsf_xml_gvalue_from_str (&val, prop_ftype, content)) {
+ if (!gsf_xml_gvalue_from_str (&val, prop_type, content)) {
g_warning ("could not convert string to type `%s' for property `%s'",
g_type_name (prop_type), state->prop_spec->name);
return;
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]