[gpm] Support for brightness_in_hardware hal property



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi everyone

I see that g-p-m supported the "brightness_in_hardware" hal property in
2.15, but it was later removed. Respecting this property seems to me
like a good idea and I can't find the reason for removal in the
changelog. Was it intentional?

I've created a patch [1] for 2.22.1 that reintroduces this feature,
since it makes g-p-m work properly with LCD brightness hotkeys on my EeePC.

For some reason the check in the code ("current_hw !=
brightness->priv->last_set_hw") that should detect if hardware changed
the brightness isn't working in all cases on Eee (for example if you
keep the hotkey pressed for some time or when you reach the upper or
lower limit).

[1]
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=respect-brightness-in-hardware.patch;att=1;bug=479089

Best regards
Tomaz Solc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIHEMIsAlAlRhL9q8RAg2+AKCjXqv6Y00PQ0AFqxGqmc2+oW+rsQCgpG7V
uYABG8zezHotutOdl6IGwyA=
=yGYF
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]