String freeze breakage in gtkhtml



Hi Radek,

There's been unannounced and unapproved string addition in gtkhtml on
gnome-2-8 branch:

#: components/html-editor/spell.c:110
msgid ""
"Unable to add word to dictionary,\n"
"language settings are broken.\n"


Gnome 2.8 is still string-frozen, so any string changes would need to
go through the procedure as outlined at:

  http://developer.gnome.org/dotplan/tasks.html#ApprovingFreezeBreaks

This is your changelog entry (though, commit happened yester):

2004-10-15  Radek Doulik  <rodo ximian com>

        * spell.c (spell_add_to_personal_no_language): new helper method
        to report broken language settings
        (spell_add_to_personal): call spell_add_to_personal_no_language if
        language is null
        (add_cb): ditto

And here's a change:
  http://cvs.gnome.org/viewcvs/gtkhtml/components/html-editor/spell.c?only_with_tag=gnome-2-8&r2=1.43.8.1&r1=1.43

It would be nice if you explained why is this change desireable on
frozen gnome-2-8 branch, or if you reverted it (provided you don't
think it's a must-have).

Cheers,
Danilo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]