Re: [Gimp-developer] Enhanced smudge tool : Smudge with painting

[Michael Natterer <mitch gimp org>]

Hi,

sorry for replying so late, we're all at LGM and quite busy.

I really love that new way of smudge painting, we absolutely
want this in 2.10.

Could you perhaps do some cleanup to the patches?

- gimp_gegl_smudge_blend() and its parameters were renamed
  for (imo) no good reason

- variables should be declared at the start of a block

- we don't use c++ comments

Also, can you upload the patches to a new bug in bugzilla
please?

Regards,
Mitch

On Fri, 2017-04-14 at 02:09 +0800, b91502038 ntu edu tw wrote:
> Hi everyone. I did an experiment that enhanced the smudge tool, which
> can not only smudge existing color on the canvas, but also blend
> brush color on it. This is useful in digital painting.
>
> Details and test drawings
> http://www.gimp-forum.net/Thread-Customized-smudge-tool-Smudge-with-p
> ainting
>
> It was not difficult to implement. Only 6 files were modified and had
> no compatibility issues.
>
> Current issues:
>
> --Color from gradient and color brushes are not supported, only
> foreground color can be used.
> I can try to fix it.
>
> --Doesn't support layer modes (multiply, screen, add, etc.)
> It's difficult to implement because smudge tool calculates brush-to-
> drawable blending by itself and calls
> gimp_brush_core_replace_canvas(), unlike other brushes.
> MyPaint brush doesn't support this either.
> I don't think this is a true problem. Normal mode is enough in
> practice. But I'm not sure other users' requirements.
>
> --Have not modifird the relative script procedure
> The "gimp-smudge" in Procedure Browser, I havn't added new parameters
> yet.
>
> An optional idea:
>
> --"No erasing effect" may be implemented as a layer property, like
> "Lock alpha channel", "Lock pixels" switches.
> That is, for any operations effecting pixels' alpha
> if(no_erasing_effect)
>   now_alpha = MAX(updated_alpha, now_alpha);
> else
>   now_alpha = updated_alpha;
> But I'm not sure the difficulty to implement and the usefulness.
> As my experience, only smudge and MyPaint brush really need this.
> _______________________________________________
> gimp-developer-list mailing list
> List address:    gimp-developer-list gnome org
> List membership: https://mail.gnome.org/mailman/listinfo/gimp-develop
> er-list
> List archives:   https://mail.gnome.org/archives/gimp-developer-list