Re: [Gimp-developer] refactor palette loading code

[Warren Turkal <wt penguintechs org>]

BTW, I tested this with gpl, act, aco, pal, and css palette files. I
couldn't find RIFF file. If anyone has one, would you mind emailing it to
me so that I can try loading it?

Thanks,
wt


On Sun, Sep 8, 2013 at 5:06 AM, Warren Turkal <wt penguintechs org> wrote:

> Hi again,
>
> Here's a link<https://github.com/wt/gimp/commit/d1e8c4c8543b18c6f5d95f6ab6b3bbbf8f80778b>to a commit 
> containing a refactor of the palette loading code. I have moved
> the file open/close logic to common code. This change actually removes more
> code than it adds. Here's a interesting diffstat (without whitespace only
> changes):
>
> $ git diff --stat --color -w origin/master
>  app/core/gimp.c               |   4 +-
>  app/core/gimppalette-import.c |  37 +++++++++--
>  app/core/gimppalette-load.c   | 148
> ++++++++++++-----------------------------
>  app/core/gimppalette-load.h   |  12 +++-
>  4 files changed, 85 insertions(+), 116 deletions(-)
>
> Any chance this could be pulled into the master? Do y'all have any other
> thoughts on this?
>
> Thanks,
> wt