Re: [gdm-list] Fixes for ConsoleKit and GDM 2.21 for Solaris

[Brian Cameron <Brian Cameron Sun COM>]

Jon:

> > gdm-rbac.diff:
> >
> >     Very similar to the ConsoleKit-02-RBAC.diff patch.  It basically
> >     fixes GDM so that polkit-gnome is an optional dependency and
> >     instead you can specify the --enable-rbac-shutdown=<key> value
> >     and it has the same meaning as for ConsoleKit.
> >
> >     The one thing I am not sure you will like is that I needed to
> >     add the "gdm-settings" code to this file so that the simple-greeter
> >     could get the GDM username from the configuration.  Perhaps this
> >     isn't necessary and I should instead fix the code to just check
> >     whatever the current user is who is running the program.   What
> >     do you think?
> >
> >     Also some cleanup in configure.ac to remove the way we used
> >     to check for RBAC in the 2.20 branch.
> >
> >     I have tested the code and it works really well.  If I define
> >     the "gdm" user to have solaris.system.shutdown RBAC key, then
> >     the buttons show up in the greeter and I have the ability to
> >     shutdown/reboot the system.  If the "gdm" user doesn' thave the
> >     RBAC key defined, the buttons don't show up and ConsoleKit
> >     does not allow me to shut down or reboot the system.
>
> Yeah, no need to query the configuration here.

You approved the updated patch I provided that just uses the current
uid.  This is now committed.  Thanks.

> > gdm-crash.diff:
> >
> >     Another NULL protection issue to avoid a crash on GDM GUI
> >     startup.
>
> Looks fine.  Please commit this.

Thanks, done.

Brian