Re: [gdm-list] gdm graphical greeter not setting default font size ?

[Brian Cameron <Brian Cameron Sun COM>]

Frederic:

> > > while investigating Mandriva bug
> > > http://qa.mandriva.com/show_bug.cgi?id=29870 and reading gdm code, it
> > > seems font size is never set in graphical greeter when not specified in
> > > theme, since it defaults to "Sans", see greeter_parser.c:1435 and
> > > according to pango_font_description_from_string API documentation,
> > > resulting information will give a font size of 0. And when
> > > do_font_size_reduction is called after, it still sets font size to 0.
> > >
> > > Shouldn't we enforce a default font size ? 10 or 12 maybe ?
> > Out of curiousity, do you have a valid value set in the GDM 
> > configuration for GtkRC.  If this is set to a valid value, it might
> > affect how fonts look.  The problem may be you have it set to an
> > invalid file?
>
> I've asked original reporter for more informations about this bug and
> problem has been fixed, so it may have been caused by a incorrect
> GtkTheme key.
>
> I tried to duplicate but I couldn't.

I'm a bit uncomfortable trying to fix a bug that can't be replicated.

> > If that doesn't fix the problem, I'd be happy to accept a patch to
> > default to a reasonable fontsize.
>
> I've discussed with Bedhad about this and he suggested to use gtkwidget
> default font description and merge the property from the theme using
> pango_font_description_merge.
>
> WDYT ?

I'd be agreeable to accepting a patch to set the default font/font size.
Perhaps it would make sense to make such a thing configurable rather
than hardcoding it in the c-code.

Brian