Re: [gamin] [PATCH 1 of 3] Apple ld does not support version-script

[Daniel Veillard <veillard redhat com>]

On Sat, May 05, 2007 at 03:39:51PM -0700, Brendan Cully wrote:
> # HG changeset patch
> # User Brendan Cully <brendan kublai com>
> # Date 1178392905 25200
> # Node ID 195b3607f4f77ca752bc954ee4293c0a27686814
> # Parent  bb83e73fd41095d98c8a83e21a717ffac1f53151
> Apple ld does not support version-script

  Sorry for coming back late to this but I didn't really had cycles for 
it before.

> diff -r bb83e73fd410 -r 195b3607f4f7 configure.in
> --- a/configure.in	Sat May 05 12:19:37 2007 -0700
> +++ b/configure.in	Sat May 05 12:21:45 2007 -0700
> @@ -33,9 +33,13 @@ AC_ISC_POSIX
>  AC_ISC_POSIX
>  AC_PROG_CC
>  AM_PROG_CC_STDC
> +AC_PROG_LD
> +AC_PROG_LD_GNU
>  AC_HEADER_STDC
>  AC_PROG_INSTALL
>  AC_PROG_MAKE_SET
> +
> +AM_CONDITIONAL([GNU_LD], [test x$lt_cv_prog_gnu_ld = xyes])
>  
>  dnl for the spec file
>  RELDATE=`date +'%a %b %e %Y'`
> diff -r bb83e73fd410 -r 195b3607f4f7 libgamin/Makefile.am
> --- a/libgamin/Makefile.am	Sat May 05 12:19:37 2007 -0700
> +++ b/libgamin/Makefile.am	Sat May 05 12:21:45 2007 -0700
> @@ -39,13 +39,18 @@ CLEANFILES=gam_error.c gam_event.c
>  
>  libgamin_1_la_LIBADD =
>  
> -libgamin_1_la_LDFLAGS = -Wl,--version-script=$(srcdir)/gamin_sym.version \
> -                        -version-info @GAMIN_VERSION_INFO@ @THREAD_LIBS@
> +libgamin_1_la_LDFLAGS = -version-info @GAMIN_VERSION_INFO@ @THREAD_LIBS@
> +if GNU_LD
> +libgamin_1_la_LDFLAGS += -Wl,--version-script=$(srcdir)/gamin_sym.version
> +endif
>  
>  libfam_la_SOURCES = $(libgamin_1_la_SOURCES)
>  libfam_la_LIBADD = $(libgamin_1_la_LIBADD)
> -libfam_la_LDFLAGS = -Wl,--version-script=$(srcdir)/gamin_sym.version	\
> -                    -version-info @FAM_VERSION_INFO@ @THREAD_LIBS@
> +libfam_la_LDFLAGS = -version-info @FAM_VERSION_INFO@ @THREAD_LIBS@
> +
> +if GNU_LD
> +libfam_la_LDFLAGS += -Wl,--version-script=$(srcdir)/gamin_sym.version
> +endif
>  
>  #
>  # Compile a program locally to check

  The problem with this patch is that instead of detecting OSX it detects
the kind of linker. Plus it doesn't replace the filtering of symbols which
is the point about libgamin/gamin_sym.version , as a result all symbols
from libgamin would be exported in the resulting shared lib and I really
think it's not proper, we just want the FAM symbols to be usable from 
applications and nothing else.
  Could you submit another patch with this fixed ?

    thanks,

Daniel


-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/