Re: [Evolution-hackers] Build failures with latest git in evolution-mapi

[Milan Crha <mcrha redhat com>]

On Tue, 2010-02-02 at 16:57 -0500, Paul Smith wrote:
>   CC     exchange-mapi-utils.lo
> In file included from /opt/evo-master/include/util.h:26,
>                  from /opt/evo-master/include/ndr.h:32,
>                  from /opt/evo-master/include/dcerpc.h:33,
>                  from /opt/evo-master/include/libmapi/libmapi.h:50,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-connection.h:31,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.h:28,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.c:29:
> /opt/evo-master/include/charset.h:125: warning: redundant
> redeclaration of 'strchr_m'
> /opt/evo-master/include/charset.h:104: note: previous declaration of
> 'strchr_m' was here
> In file included from /opt/evo-master/include/dcerpc.h:33,
>                  from /opt/evo-master/include/libmapi/libmapi.h:50,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-connection.h:31,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.h:28,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.c:29:
> /opt/evo-master/include/ndr.h:517: warning: redundant redeclaration of
> 'ndr_print_bitmap_flag'
> /opt/evo-master/include/ndr.h:516: note: previous declaration of
> 'ndr_print_bitmap_flag' was here
> In file included from /opt/evo-master/include/gen_ndr/exchange.h:9,
>                  from /opt/evo-master/include/libmapi/libmapi.h:57,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-connection.h:31,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.h:28,
> 
> from ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.c:29:
> /opt/evo-master/include/gen_ndr/ndr_misc.h:12: warning: redundant
> redeclaration of 'ndr_print_GUID'
> /opt/evo-master/include/ndr.h:375: note: previous declaration of
> 'ndr_print_GUID' was here
> /opt/evo-master/include/gen_ndr/ndr_misc.h:17: warning: redundant
> redeclaration of 'ndr_push_policy_handle'
> /opt/evo-master/include/ndr.h:493: note: previous declaration of
> 'ndr_push_policy_handle' was here
> /opt/evo-master/include/gen_ndr/ndr_misc.h:18: warning: redundant
> redeclaration of 'ndr_pull_policy_handle'
> /opt/evo-master/include/ndr.h:492: note: previous declaration of
> 'ndr_pull_policy_handle' was here
> /opt/evo-master/include/gen_ndr/ndr_misc.h:19: warning: redundant
> redeclaration of 'ndr_print_policy_handle'
> /opt/evo-master/include/ndr.h:494: note: previous declaration of
> 'ndr_print_policy_handle' was here

	Hi,
I see these as well, but didn't figure out what's going on. I was told
about two different samba's installed, but I didn't check that yet.
Though what we have common is a different install prefix from the one
used by default, which is /usr/local/samba.

> ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.c:
> In function 'utf8tolinux':
> ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.c:71: error: implicit declaration of function 'windows_to_utf8'
> ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.c:71: warning: nested extern declaration of 'windows_to_utf8'
> ../../../../evolution-mapi/src/libexchangemapi/exchange-mapi-utils.c:71: warning: assignment makes pointer from integer without a cast
> make[4]: *** [exchange-mapi-utils.lo] Error 1
> make[4]: Leaving directory
> `/opt/src/evo/evo-master/obj/evolution-mapi/src/libexchangemapi' 

windows_to_utf8 was removed in Openchange trunk, in favor of correct fix
for this. You can change the utf8tolinux in your build to simply
return g_strdup (wstring);
and that's it. The function had some issues, was able to drop letters
like @!,() from strings, if you noticed.

It's still under its way, but better now. With respect of fixes around
this in evolution-mapi and openchange you mentioned in the other email,
there was a change for reading values in evolution-mapi, but changes for
writing values were in openchange. For example, if your subject contains
any utf8 letter, then that will be properly encoded in the openchange
functions in actual trunk, where it just failed to send such message
before the change. I do not want to go too far with details, thus just
saying there is still some effort to fix even more cases for this,
initially in openchange, and if required then also on evolution-mapi
side, for better experience with utf8 strings received/sent with MAPI.
	Bye,
	Milan