Re: Unreviewed Patches

[Marco Pesenti Gritti <mpgritti gmail com>]

On Apr 3, 2005 11:35 AM, Christian Persch <chpe gnome org> wrote:
> Hi,
> 
> Le dimanche 03 avril 2005 à 11:15 +0200, Marco Pesenti Gritti a écrit :
> > > > 170111        Toolbar in fullscreen mode doesn't respect Btoolbar
> > > > settings
> > > >       http://bugzilla.gnome.org/show_bug.cgi?id=170111
> > >
> > > I don't understand why we're overriding this to begin with.  Marco, do
> > > you know the history of this line?
> >
> > Fullscreen was ported from epiphany, I guess this was so that the
> > toolbar would take less vertical space. Though it doesnt make much
> > sense when the user choosen mode is icon/text only.
> >
> > CCing Christian
> 
> All I can offer is your checkin comment when you wrote this:
> "Special, more compact, toolbar layout for fullscreen." :)

Yeah I think that was the reason then.

Bryan, it's up to you basically. We could see if it's possible to
override the mode only in text+icons case... if it's worth. Otherwise
please just commit your patch.

Marco