Re: [Easytag-mailing] EasyTAG 0.30.1 has been released! (Developing Version)

[Jérôme Couderc <j couderc ifrance com>]

Hi Daniel,

Here is a patch that fixes the problem...

Regards,
Jerome


Daniel Drake wrote:
> Jérôme COUDERC wrote:
>
> >        A new developing version of EasyTAG have been released today.
> > This version contains a lot of changes, so inform me if you find any bug.
>
>
> Here's one. Playing with ./configure flags.
>
> Normal ./configure gives:
> [...]
> checking for ogg_sync_init in -logg... yes
> checking for vorbis_comment_init in -lvorbis... yes
> checking for ov_open in -lvorbisfile... yes
> checking for Ogg Vorbis file support... yes
> checking for FLAC__metadata_simple_iterator_new in -lFLAC... yes
> checking for FLAC file support... yes
> checking for libFLAC version... 1.1.0
> checking for library containing ID3Tag_Link... -lid3 -lz -lstdc++
> checking for id3lib version... 3.8.3
> [...]
>  Id3lib version ..........: 3.8.3
>  NLS/gettext .............: yes
>  Ogg Vorbis file support .: yes
>  FLAC file support .......: yes (version 1.1.0)
>
> All good - OGG and FLAC support is detected and registered.
>
>
> Now for ./configure --disable-flac
> [...]
> checking for ogg_sync_init in -logg... yes
> checking for vorbis_comment_init in -lvorbis... yes
> checking for ov_open in -lvorbisfile... yes
> checking for Ogg Vorbis file support... yes
> checking for FLAC file support... no
> ***
> *** Warning: FLAC file support disabled!         ***
> *** (You must install flac library to enable it) ***
> ***
> checking for library containing ID3Tag_Link... -lid3 -lz -lstdc++
> [...]
>  Id3lib version ..........: 3.8.3
>  NLS/gettext .............: yes
>  Ogg Vorbis file support .: yes
>  FLAC file support .......: no
>
> Apart from the slightly misleading warning, all is good (flac disabled, 
> as I requested on the command line).
>
> Now for ./configure --disable-ogg
> [...]
> checking for Ogg Vorbis file support... no
> ***
> *** Warning: Ogg Vorbis file support disabled!                     ***
> *** (You must install libogg and libvorbis libraries to enable it) ***
> ***
> checking for FLAC__metadata_simple_iterator_new in -lFLAC... no
> checking for FLAC file support... no
> ***
> *** Warning: FLAC file support disabled!         ***
> *** (You must install flac library to enable it) ***
> ***
> checking for library containing ID3Tag_Link... -lid3 -lz -lstdc++
> [...]
>  Id3lib version ..........: 3.8.3
>  NLS/gettext .............: yes
>  Ogg Vorbis file support .: no
>  FLAC file support .......: no
> [...]
>
> This is the problem - FLAC got disabled as well, even though I only 
> turned ogg off.
>
> Do they depend on each other, or is this a bug?
>
> Sorry, haven't had a chance to try and reproduce on another system yet.
>
> Daniel
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click
> _______________________________________________
> Easytag-mailing mailing list
> Easytag-mailing lists sourceforge net
> https://lists.sourceforge.net/lists/listinfo/easytag-mailing
>
> ___[ Pub ]____________________________________________________________
> Inscrivez-vous gratuitement sur Tandaime et gagnez un voyage à Venise
> www.Tandaime.com/index.php?origine=Tandaime, et la vie vous sourit !

--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC <j couderc ifrance com>

diff -ruN easytag-0.30.1.orig/configure easytag-0.30.1/configure
--- easytag-0.30.1.orig/configure	Sun Feb  1 00:18:17 2004
+++ easytag-0.30.1/configure	Wed Mar 24 19:34:00 2004
@@ -7920,6 +7920,70 @@
 
 if test "x$enable_flac" = "xyes"; then
 
+echo "$as_me:$LINENO: checking for cos in -lm" >&5
+echo $ECHO_N "checking for cos in -lm... $ECHO_C" >&6
+if test "${ac_cv_lib_m_cos+set}" = set; then
+  echo $ECHO_N "(cached) $ECHO_C" >&6
+else
+  ac_check_lib_save_LIBS=$LIBS
+LIBS="-lm  $LIBS"
+cat >conftest.$ac_ext <<_ACEOF
+#line $LINENO "configure"
+#include "confdefs.h"
+
+/* Override any gcc2 internal prototype to avoid an error.  */
+#ifdef __cplusplus
+extern "C"
+#endif
+/* We use char because int might match the return type of a gcc2
+   builtin and then its argument prototype would still apply.  */
+char cos ();
+#ifdef F77_DUMMY_MAIN
+#  ifdef __cplusplus
+     extern "C"
+#  endif
+   int F77_DUMMY_MAIN() { return 1; }
+#endif
+int
+main ()
+{
+cos ();
+  ;
+  return 0;
+}
+_ACEOF
+rm -f conftest.$ac_objext conftest$ac_exeext
+if { (eval echo "$as_me:$LINENO: \"$ac_link\"") >&5
+  (eval $ac_link) 2>&5
+  ac_status=$?
+  echo "$as_me:$LINENO: \$? = $ac_status" >&5
+  (exit $ac_status); } &&
+         { ac_try='test -s conftest$ac_exeext'
+  { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
+  (eval $ac_try) 2>&5
+  ac_status=$?
+  echo "$as_me:$LINENO: \$? = $ac_status" >&5
+  (exit $ac_status); }; }; then
+  ac_cv_lib_m_cos=yes
+else
+  echo "$as_me: failed program was:" >&5
+cat conftest.$ac_ext >&5
+ac_cv_lib_m_cos=no
+fi
+rm -f conftest.$ac_objext conftest$ac_exeext conftest.$ac_ext
+LIBS=$ac_check_lib_save_LIBS
+fi
+echo "$as_me:$LINENO: result: $ac_cv_lib_m_cos" >&5
+echo "${ECHO_T}$ac_cv_lib_m_cos" >&6
+if test $ac_cv_lib_m_cos = yes; then
+  cat >>confdefs.h <<_ACEOF
+#define HAVE_LIBM 1
+_ACEOF
+
+  LIBS="-lm $LIBS"
+
+fi
+
 echo "$as_me:$LINENO: checking for FLAC__metadata_simple_iterator_new in -lFLAC" >&5
 echo $ECHO_N "checking for FLAC__metadata_simple_iterator_new in -lFLAC... $ECHO_C" >&6
 if test "${ac_cv_lib_FLAC_FLAC__metadata_simple_iterator_new+set}" = set; then
diff -ruN easytag-0.30.1.orig/configure.in easytag-0.30.1/configure.in
--- easytag-0.30.1.orig/configure.in	Sun Feb  1 00:18:05 2004
+++ easytag-0.30.1/configure.in	Wed Mar 24 19:33:50 2004
@@ -85,6 +85,7 @@
 dnl check for system libflac
 if test "x$enable_flac" = "xyes"; then
     dnl Library required for flac files, if not found 'enable_flac' is disabled
+    AC_CHECK_LIB(m, cos) dnl Patch from Christian Weisgerber
     AC_CHECK_LIB(FLAC, FLAC__metadata_simple_iterator_new, , enable_flac=no)
     dnl AM_PATH_LIBFLAC(enable_flac="yes",enable_flac="no")
 fi