Cole Robinson wrote:
Hi all, Attached is a patch that adds a config option to suppress printing log output to stdout. For testing at build time this is nice as a lot of the log messages don't indicate failure and thus should be at the discretion of the tester.
Hi Cole,OK, that's fair. Only thing I would change would be the actual name of the option, so that it would better fit the naming scheme of the rest - something like logDebugToStdOut. Long, but consistent nonetheless.
Also there is a fix for a bug in here: if creating a log file fails, logger.file is still True, so if anything tries to then log a message, an exception is thrown. The fix was just to explicitly set logger.file to False when creating the log file fails.
Er... oops! Thanks for catching that. Zack