Re: Dia custom lines objects patch UPDATE (against svn rev. 3875)

[Hans Breuer <hans breuer org>]

Hi Marcel,
sorry for not commenting earlier. I only found the time to look at your 
patch a few days ago. Unfortunately the way it was done is not portable.
As already noted in the ChangeLog ObjectTypeOps or even the Object 
definitions are not meant to be reused the way you did.

I just comitted the following to fix this:

2008-03-05  Hans Breuer  <hans breuer org>

        * objects/standard/(bezier|polyline|zigzagline).c : reverted    changes
        from revision 3878. Object plug-in internals must not be made public.
        Also the way it was done was not portable.
        * objects/standard/(bezier|polyline|zigzagline).h : deleted
        * objects/custom_lines/custom_linetypes.c : almost complete rewrite
        using only public APIs
        * objects/custom_lines/custom_lines.c
          objects/custom_lines/custom_linetypes.h : custom_linetypes_init();
        not any longer necessary.
        * objects/standard/Makefile.am objects/custom_lines/Makefile.am
          objects/makefile.msc : adapted (reverting the tricks to make
        'make distcheck' pass


Am 11.01.2008 14:07, Marcel Toele schrieb:
[...]
> Todo:
>      - Line appearance can be manually altered after placing,
>        the dialog hasn't been disabled yet as this is a non-trivial task.
I'm not sure if this a bug or a feature. Maybe the custom-lines types 
should just be used as templates, i.e. only change creation presets but 
afterwards just become normal standard objects?

Another thing missing is some sample/use of this plug-in in Dia's standard 
distribution. Having to download your "Demo, Custom Lines" to test the 
plug-in looks like a recipe to have it bitrotten more sooner than later.

Thanks,
        Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert