Re: Integrated UI patch

["Patrick Hallinan" <patrick j hallinan gmail com>]

On 7/22/07, Steffen Macke <sdteffen gmail com> wrote:

Hi Patrick,

the patch looks fine, I've applied it to the SVN repository.

The "x" to close a tab is still not working for me.

I've attached a patch to fix the "x" close tab problem.  It couldn't work on any system the way it was.  I must have made a last minute change and tested the change without compiling or something. 

Index: interface.c
===================================================================
--- interface.c	(revision 3734)
+++ interface.c	(working copy)
@@ -505,6 +505,9 @@
   gtk_box_pack_start( GTK_BOX(tab_label_container), label, FALSE, FALSE, 0 );
   gtk_widget_show (label);
 
+  /* Create a new tab page */
+  ddisp->container = gtk_vbox_new(FALSE, 0);
+
   /* <from GEdit> */
   /* don't allow focus on the close button */
   close_button = gtk_button_new();
@@ -525,12 +528,11 @@
                       GTK_SIGNAL_FUNC (close_notebook_page_callback), ddisp->container);
   /* </from GEdit> */
 
+  /* Set events for new tab page */
   gtk_box_pack_start( GTK_BOX(tab_label_container), close_button, FALSE, FALSE, 0 );
   gtk_widget_show (close_button);
   gtk_widget_show (image);
 
-  /* Create a new tab page */
-  ddisp->container = gtk_vbox_new(FALSE, 0);
   gtk_widget_set_events (ddisp->container,
                          GDK_POINTER_MOTION_MASK |
                          GDK_POINTER_MOTION_HINT_MASK |