Re: List translators script

[Simos Xenitellis <simos lists googlemail com>]

On Wed, May 20, 2009 at 8:29 PM, daniel g. siegel <dgsiegel gmail com> wrote:

On Mi, 2009-05-20 at 14:59 +0200, Vincent Untz wrote:
> Le lundi 18 mai 2009, à 23:01 +0200, daniel g. siegel a écrit :
> > i have also working list_translators.sh here, which i enhanced to my
> > needs. please find it attached.
>
> You're missing " -- $1" in diff_files.

and youre right ;)

fixed version is attached

A final touch is to change

function diff_files() {
  git diff $TAG..HEAD --name-only -- $1 | grep "\.po$"
}

to 

diff_files() {
  git diff $TAG..HEAD --name-only -- $1 | grep "\.po$"

}

The 'function' build-in is a bash-ism, which does not work with 'dash', the default shell in Ubuntu (and probably elsewhere).
Bash is still OK when you don't specify the 'function' built-in.

Simos