[gnome-shell] altTab: Always include label in thumbnail



commit 022c64961c22afcfe865186b5e190a7c9446ff15
Author: Florian Müllner <fmuellner gnome org>
Date:   Mon Sep 12 16:44:27 2022 +0200

    altTab: Always include label in thumbnail
    
    We currently special-case the no-window-title case when creating
    items, but not when accessing labels later, for example during
    allocation.
    
    The easiest option it to create the label unconditionally, so do
    that.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5851
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2483>

 js/ui/altTab.js | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)
---
diff --git a/js/ui/altTab.js b/js/ui/altTab.js
index 95dc75f02a..a3daebc20d 100644
--- a/js/ui/altTab.js
+++ b/js/ui/altTab.js
@@ -917,20 +917,16 @@ class ThumbnailSwitcher extends SwitcherPopup.SwitcherList {
             box.add_actor(bin);
             this._thumbnailBins.push(bin);
 
-            let title = windows[i].get_title();
-            if (title) {
-                let name = new St.Label({
-                    text: title,
-                    // St.Label doesn't support text-align
-                    x_align: Clutter.ActorAlign.CENTER,
-                });
-                this._labels.push(name);
-                box.add_actor(name);
+            const title = windows[i].get_title();
+            const name = new St.Label({
+                text: title,
+                // St.Label doesn't support text-align
+                x_align: Clutter.ActorAlign.CENTER,
+            });
+            this._labels.push(name);
+            box.add_actor(name);
 
-                this.addItem(box, name);
-            } else {
-                this.addItem(box, null);
-            }
+            this.addItem(box, name);
         }
 
         this.connect('destroy', this._onDestroy.bind(this));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]